vault-action icon indicating copy to clipboard operation
vault-action copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

fix: remove case transformation in normalizeOutputKey

Open martinsolberg opened this issue 11 months ago • 3 comments

Description

Removes case transformation in normalizeOutputKey. Will allow keys to be exported as environment variables with case intact when using wildcard lookup.

Closes #536

Checklist

  • [ ] Added CHANGELOG entry (only for user-facing changes)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

martinsolberg avatar Mar 20 '24 13:03 martinsolberg

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 20 '24 13:03 hashicorp-cla

@martinsolberg Hi, I am sorry you are having trouble here. I think this use case makes sense. However, I think this may be a breaking change. (I haven't tested it or run the acceptance tests yet). How will this change affect the existing behavior of normalizing the selector key: https://github.com/hashicorp/vault-action?tab=readme-ov-file#simple-key?

fairclothjm avatar Mar 20 '24 13:03 fairclothjm

@fairclothjm That may very well be the case, I do not have sufficient insight to make a judgement on that. If this change introduces some unfortunate consequences, someone else will have to have a go at it.

martinsolberg avatar Mar 20 '24 14:03 martinsolberg

Use #545 to resolve this issue instead

martinsolberg avatar Jun 24 '24 08:06 martinsolberg