vagrant icon indicating copy to clipboard operation
vagrant copied to clipboard

Update configure_disks.rb

Open camillo-toselli opened this issue 1 year ago • 6 comments

fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,

camillo-toselli avatar Jan 30 '24 10:01 camillo-toselli

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jan 30 '24 10:01 hashicorp-cla

Added double splat to created_disk and attach_disk invocations to explicitly allow the implicit conversions disabled in Ruby 3.x. This fix makes the creation and removal of disks by the hyper-v provider start working again.

camillo-toselli avatar Jan 30 '24 10:01 camillo-toselli

Dear mantainers,

can we proceed with workflows approval? can you enable me to run workflows needed for final review? These simple changes make hyperv disk configuration work correctly also on Ruby 3.xx. Thanks in advance,

Best regards.

Camillo

camillo-toselli avatar Feb 20 '24 09:02 camillo-toselli

Camillo - appreciate you sharing this fix... hopefully it gets reviewed and merged soon.

PaulNacamuli avatar Apr 10 '24 17:04 PaulNacamuli

Dear Paul - Thank you. Have you any news about any incoming review?

camillo-toselli avatar Apr 16 '24 13:04 camillo-toselli

No. I'm not a maintainer, just a user.

On Tue, Apr 16, 2024, 06:45 Camillo Toselli @.***> wrote:

Dear Paul - Thank you. Have you any news about any incoming review?

— Reply to this email directly, view it on GitHub https://github.com/hashicorp/vagrant/pull/13346#issuecomment-2059131859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU3TQYUUPOCWMPG7TVFYJSLY5UTNXAVCNFSM6AAAAABCQ674V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGEZTCOBVHE . You are receiving this because you commented.Message ID: @.***>

PaulNacamuli avatar Apr 17 '24 12:04 PaulNacamuli

Thanks for this PR and my apologies for the delay in getting reviewed and merged!

chrisroberts avatar Jul 11 '24 00:07 chrisroberts

Thank you so much!

Camillo

camillo-toselli avatar Jul 11 '24 07:07 camillo-toselli