vagrant
vagrant copied to clipboard
Update configure_disks.rb
fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,
Added double splat to created_disk and attach_disk invocations to explicitly allow the implicit conversions disabled in Ruby 3.x. This fix makes the creation and removal of disks by the hyper-v provider start working again.
Dear mantainers,
can we proceed with workflows approval? can you enable me to run workflows needed for final review? These simple changes make hyperv disk configuration work correctly also on Ruby 3.xx. Thanks in advance,
Best regards.
Camillo
Camillo - appreciate you sharing this fix... hopefully it gets reviewed and merged soon.
Dear Paul - Thank you. Have you any news about any incoming review?
No. I'm not a maintainer, just a user.
On Tue, Apr 16, 2024, 06:45 Camillo Toselli @.***> wrote:
Dear Paul - Thank you. Have you any news about any incoming review?
— Reply to this email directly, view it on GitHub https://github.com/hashicorp/vagrant/pull/13346#issuecomment-2059131859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU3TQYUUPOCWMPG7TVFYJSLY5UTNXAVCNFSM6AAAAABCQ674V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGEZTCOBVHE . You are receiving this because you commented.Message ID: @.***>
Thanks for this PR and my apologies for the delay in getting reviewed and merged!
Thank you so much!
Camillo