vagrant icon indicating copy to clipboard operation
vagrant copied to clipboard

docs: fix typo and clarify sentence

Open siiky opened this issue 3 years ago • 1 comments

siiky avatar Oct 04 '22 14:10 siiky

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Oct 04 '22 14:10 hashicorp-cla

Hi @siiky! I've just merged in https://github.com/hashicorp/vagrant/pull/13048, which modified 120 MDX files and added a new workflow that would be good to have run on this PR. Since this is from a fork, I'm not sure I have permissions to rebase on main for you, so I wanted to send this quick message to let you know to update with main. Thanks!

ashleemboyer avatar Jan 20 '23 22:01 ashleemboyer

I'll try to rebase it later today, no problem.

siiky avatar Jan 21 '23 13:01 siiky

@ashleemboyer Took me a littler longer but here it is.

siiky avatar Jan 22 '23 16:01 siiky

Thanks for trying to make the Vagrant docs better! We appreciate the time you took to look at our documentation and submit this PR. I think these changes can be expanded on a little more. I’ve done that in this change https://github.com/hashicorp/vagrant/pull/13085. So, I’m going to go ahead and close this PR.

soapy1 avatar Feb 15 '23 18:02 soapy1

Well, it's your project after all, so if you think so...

siiky avatar Feb 16 '23 09:02 siiky