terraform icon indicating copy to clipboard operation
terraform copied to clipboard

Fix IAM Policy Documentation for S3 Backend

Open ajschmidt8 opened this issue 1 year ago • 5 comments

This PR fixes the documentation for the S3 backend.

The current DynamoDB IAM policy states that the lock key path should be prefixed with the DynamoDB table name. This is incorrect. As indicated by the source code below, the lock key path is prefixed by the S3 bucket name, not the DynamoDB table name.

  • https://github.com/hashicorp/terraform/blob/a73e4e658648e0d507e89c4cd389a2af5edf9395/internal/backend/remote-state/s3/client.go#L495-L497

I've also updated the bucket's name to BucketName to match the DynamoDB table name, TableName.

ajschmidt8 avatar May 31 '24 14:05 ajschmidt8

CLA assistant check
All committers have signed the CLA.

hashicorp-cla-app[bot] avatar May 31 '24 14:05 hashicorp-cla-app[bot]

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla-app[bot] avatar May 31 '24 14:05 hashicorp-cla-app[bot]

Thanks for this submission!

crw avatar Jun 03 '24 22:06 crw

Hey @ajschmidt8 , it looks like the email you signed the CLA with ([email protected]) doesn't match the commit author :

From bd9c41c5a50ec2d924682121a58f8189e9c6023c Mon Sep 17 00:00:00 2001 From: AJ Schmidt [email protected] Date: Fri, 31 May 2024 10:38:33 -0400

The CLA bot checks that the commit author matches the signer, so if you could get those two matched up, you should be ok!

dlaguerta avatar Jun 25 '24 16:06 dlaguerta

Hey @ajschmidt8 , it looks like the email you signed the CLA with ([email protected]) doesn't match the commit author :

From bd9c41c Mon Sep 17 00:00:00 2001 From: AJ Schmidt [email protected] Date: Fri, 31 May 2024 10:38:33 -0400

The CLA bot checks that the commit author matches the signer, so if you could get those two matched up, you should be ok!

It should be fixed in my latest commit, d7cac95834eecde22497c41dfb977686a81bf83c.

ajschmidt8 avatar Jun 25 '24 17:06 ajschmidt8

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

github-actions[bot] avatar Sep 23 '24 23:09 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Oct 24 '24 02:10 github-actions[bot]