Add support for a `vsphere_virtual_disk_attachment` resource

[xelite]

Terraform Version

0.12

vSphere Provider Version

vsphere_v1.12.0_x4

I want to be able to create vm and attach to them additional disks created with vsphere_virtual_disk resource. Currently it is not possible without modify vsphere_virtual_machine which is not uncomfortable, beacuse I've got several modules with different num of disks. Moreover terraform is detaching disk that was attached manually with sufficiently clear message. Current plan:

      ~ disk {
          ~ label            = "orphaned_disk_0" -> "<remove, keep disk>"
        }

It should be something like:

      ~ disk {
          ~ label            = "orphaned_disk_0" -> "disk will be detached from vm"
        }

[hashibot]

This issue has been open 180 days with no activity. If this issue is reproducible with the latest version of the provider and with Terraform 0.12, please comment. Otherwise this issue will be closed in 30 days.

[xelite]

This is still reproducible

[bill-rich]

This seems reasonable, and this same model will probably be good for working with over virtual machine sub resources. This isn't a top priority since we have an alternate way of working with the disks, but I'm going to plan on looking into this for our v2.0 release of the provider.