terraform-provider-vsphere icon indicating copy to clipboard operation
terraform-provider-vsphere copied to clipboard

Add support for including a `description` attribute in `r/vsphere_role`

Open MarcusFoelling opened this issue 2 years ago • 2 comments

Community Guidelines

  • [X] I have read and agree to the HashiCorp Community Guidelines .
  • [x] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • [x] Do not leave "+1" or other comments that do not add relevant information or questions.
  • [x] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

it seems that current implementation of vsphere_role resource of hashicorp/vsphere provider is lacking the ability to define the description property of a given vCenter Role

Use Case(s)

current implementation does not allow to configure mentioned content

Potential Terraform Provider Configuration

resource vsphere_role "role1" {
  name = "my_terraform_role"
  description = "this role can manage alerts and datacenters"
  role_privileges = ["Alarm.Acknowledge", "Alarm.Create", "Datacenter.Create", "Datacenter.Move"]
}

References

https://registry.terraform.io/providers/hashicorp/vsphere/latest/docs/resources/vsphere_role

MarcusFoelling avatar Aug 19 '22 13:08 MarcusFoelling

Hello, MarcusFoelling! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

github-actions[bot] avatar Aug 19 '22 13:08 github-actions[bot]

AuthorizationManager.AddRole in vmware/govomi does not support the inclusion of the description (summary) to the pass to the resource

There is an upstream requirement.

https://github.com/vmware/govmomi/blob/bb0307eb84ae981cfca7fc8d680821a2c2be3c6d/object/authorization_manager.go#L138-L143

https://github.com/hashicorp/terraform-provider-vsphere/blob/2f53f7a557185a49b97313de823d663935d089de/vsphere/resource_vsphere_role.go#L48-L64

Ryan Johnson Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam avatar Aug 19 '22 13:08 tenthirtyam

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

github-actions[bot] avatar Mar 06 '23 00:03 github-actions[bot]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jun 04 '23 02:06 github-actions[bot]