terraform-provider-vault icon indicating copy to clipboard operation
terraform-provider-vault copied to clipboard

`vault_terraform_cloud_secret_backend` add write-only argument

Open drewmullen opened this issue 6 months ago • 0 comments

Description

Relates OR Closes https://github.com/hashicorp/terraform-provider-vault/issues/2453

Checklist

  • [x] Added CHANGELOG entry (only for user-facing changes)
  • [x] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ TF_ACC=1 go test -v -run TestTerraformCloudSecretBackend -timeout 10m ./...
<redacted>
ok  	github.com/hashicorp/terraform-provider-vault/util/mountutil	(cached) [no tests to run]
=== RUN   TestTerraformCloudSecretBackend
--- PASS: TestTerraformCloudSecretBackend (0.90s)
=== RUN   TestTerraformCloudSecretBackend_remount
--- PASS: TestTerraformCloudSecretBackend_remount (2.07s)
=== RUN   TestTerraformCloudSecretBackend_token_wo
--- PASS: TestTerraformCloudSecretBackend_token_wo (0.87s)
=== RUN   TestTerraformCloudSecretBackendRoleNameFromPath
--- PASS: TestTerraformCloudSecretBackendRoleNameFromPath (0.00s)
=== RUN   TestTerraformCloudSecretBackendRoleBackendFromPath
--- PASS: TestTerraformCloudSecretBackendRoleBackendFromPath (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	4.612s

This doesnt seem to do anything but is mentioned in the PR template so I am including. See ACC test runs above:

$ make testacc TESTARGS='-run=TestTerraformCloudSecretBackend'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestTerraformCloudSecretBackend -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.192s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/framework/base	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/framework/client	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/framework/errutil	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/framework/model	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/framework/validators	0.287s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	0.436s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	0.479s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/provider/fwprovider	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/providertest	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/rotation	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/sync	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/vault/secrets/ephemeral	0.576s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/vault/sys	1.005s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	0.538s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	0.715s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util/mountutil	1.041s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	4.874s
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

drewmullen avatar May 30 '25 12:05 drewmullen