terraform-provider-vault icon indicating copy to clipboard operation
terraform-provider-vault copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Commit to address 297

Open benemon opened this issue 1 year ago • 2 comments

Description

Added the persist_apps field to the vault_azure_secret_backend_role resource.

Closes #2297

Checklist

  • [ ] Added CHANGELOG entry (only for user-facing changes)
  • [ ] Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

benemon avatar Jul 18 '24 17:07 benemon

Can we also add our new param to our docs: https://github.com/hashicorp/terraform-provider-vault/blob/main/website/docs/r/azure_secret_backend_role.html.md?plain=1

Zlaticanin avatar Jan 09 '25 20:01 Zlaticanin

Thank you so much @benemon for your contribution. Could you please review my comments above and update the PR? Thank you again 🙏

Zlaticanin avatar Jan 09 '25 20:01 Zlaticanin