terraform-provider-vault icon indicating copy to clipboard operation
terraform-provider-vault copied to clipboard

Add resource_userpass_user

Open blmhemu opened this issue 2 years ago • 9 comments

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1015

Release note for CHANGELOG:

* Added new `resource_userpass_user` to create new users (with password) and assign token properties.
* Minor documentation fix.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccUserpass'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccUserpass -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	4.990s

blmhemu avatar Mar 20 '23 07:03 blmhemu

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 20 '23 07:03 hashicorp-cla

Hi @vinay-gopalan ! I could not find a guide on how to create docs. Is there an automated command which can do this ? Also a review would be great.

blmhemu avatar Mar 28 '23 05:03 blmhemu

Hi, are there any updates on this? 😀

Best Patrick

PatrickLaabs avatar May 16 '23 19:05 PatrickLaabs

Team ! I understand that you might be busy, but this has been open for 2 months without any reviews - can I get some reviews / approval here ?

blmhemu avatar May 19 '23 14:05 blmhemu

@blmhemu Thanks for the submission! Are you still interested in carrying this forward?

fairclothjm avatar Jun 20 '23 17:06 fairclothjm

@fairclothjm Yep, I plan to resolve comments in a couple of weeks.

blmhemu avatar Jun 21 '23 02:06 blmhemu

Have re-worked the PR to include the nice suggestions. Please re-review. cc: @vinay-gopalan

blmhemu avatar Jul 10 '23 15:07 blmhemu

Any updates here? I'm really looking forward to this piece of functionality.

CiucurDaniel avatar Nov 03 '23 10:11 CiucurDaniel