terraform-provider-vault
terraform-provider-vault copied to clipboard
Add username_template support for mongodbatlas in database_secret_backend_connection
This change adds username_template
field to mongodbatlas block in vault_database_secret_backend_connection
resource.
Community Note
- Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
- Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request
Closes #1240
Release note for CHANGELOG:
Add username_template to vault_database_secret_backend_connection for mongodbatlas block
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run=TestAccDatabaseSecretBackendConnection -timeout 20m
? github.com/hashicorp/terraform-provider-vault [no test files]
? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files]
? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/codegen 0.263s [no tests to run]
? github.com/hashicorp/terraform-provider-vault/generated [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode 0.779s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode 0.301s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet 0.538s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role 1.029s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template 1.534s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation 1.287s [no tests to run]
? github.com/hashicorp/terraform-provider-vault/helper [no test files]
? github.com/hashicorp/terraform-provider-vault/schema [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/util 0.321s [no tests to run]
=== RUN TestAccDatabaseSecretBackendConnection_import
resource_database_secret_backend_connection_test.go:20: POSTGRES_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_import (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_cassandra
resource_database_secret_backend_connection_test.go:61: CASSANDRA_HOST not set
--- SKIP: TestAccDatabaseSecretBackendConnection_cassandra (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_cassandraProtocol
resource_database_secret_backend_connection_test.go:104: CASSANDRA_HOST not set
--- SKIP: TestAccDatabaseSecretBackendConnection_cassandraProtocol (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_influxdb
resource_database_secret_backend_connection_test.go:147: INFLUXDB_HOST not set
--- SKIP: TestAccDatabaseSecretBackendConnection_influxdb (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_mongodbatlas
resource_database_secret_backend_connection_test.go:189: MONGODB_ATLAS_PUBLIC_KEY not set
--- SKIP: TestAccDatabaseSecretBackendConnection_mongodbatlas (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_mongodb
resource_database_secret_backend_connection_test.go:226: MONGODB_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_mongodb (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_mssql
resource_database_secret_backend_connection_test.go:256: MSSQL_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_mssql (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_mysql
resource_database_secret_backend_connection_test.go:289: MYSQL_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_mysql (0.00s)
=== RUN TestAccDatabaseSecretBackendConnectionUpdate_mysql
resource_database_secret_backend_connection_test.go:376: MYSQL_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnectionUpdate_mysql (0.00s)
=== RUN TestAccDatabaseSecretBackendConnectionTemplatedUpdateExcludePassword_mysql
resource_database_secret_backend_connection_test.go:429: MYSQL_CONNECTION_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnectionTemplatedUpdateExcludePassword_mysql (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_mysql_tls
resource_database_secret_backend_connection_test.go:512: MYSQL_CA not set
--- SKIP: TestAccDatabaseSecretBackendConnection_mysql_tls (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_postgresql
resource_database_secret_backend_connection_test.go:558: POSTGRES_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_postgresql (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_elasticsearch
resource_database_secret_backend_connection_test.go:593: ELASTIC_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_elasticsearch (0.00s)
=== RUN TestAccDatabaseSecretBackendConnection_snowflake
resource_database_secret_backend_connection_test.go:625: SNOWFLAKE_URL not set
--- SKIP: TestAccDatabaseSecretBackendConnection_snowflake (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-vault/vault 1.681s
Hi, any idea when this PR will be merged? I need to implement this feature, and it currently only works via vault cli. Thanks for the update.
Hi, any idea when this PR will be merged?
+1
+1