terraform-provider-kubernetes icon indicating copy to clipboard operation
terraform-provider-kubernetes copied to clipboard

add sub_path_expr to volume_mount

Open benjah1 opened this issue 4 years ago • 8 comments

Description

Add sub_path_expr to volume_mount.

Acceptance tests

  • [X] Have you added an acceptance test for the functionality being added?
  • [X] Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)
root@ubuntu-bionic:/app# KUBE_CTX=kind-kind TESTARGS="-run '^TestAccKubernetesPod_.*volume.*'" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./kubernetes" -v -run '^TestAccKubernetesPod_.*volume.*' -timeout 120m
=== RUN   TestAccKubernetesPod_with_volume_mount
--- PASS: TestAccKubernetesPod_with_volume_mount (21.84s)
=== RUN   TestAccKubernetesPod_with_volume_mount_sub_path_expr
--- PASS: TestAccKubernetesPod_with_volume_mount_sub_path_expr (21.27s)
=== RUN   TestAccKubernetesPod_with_cfg_map_volume_mount
--- PASS: TestAccKubernetesPod_with_cfg_map_volume_mount (24.52s)
=== RUN   TestAccKubernetesPod_with_empty_dir_volume
--- PASS: TestAccKubernetesPod_with_empty_dir_volume (9.19s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   76.880s

Will post a full testacc run once finished.

References

#920

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

benjah1 avatar Jul 21 '20 23:07 benjah1

full testacc run with kind. https://gist.github.com/benjah1/1e634f0f14aec980acd6816d9ea14f82

benjah1 avatar Jul 22 '20 01:07 benjah1

Resolved conflict.

Hi @aareet, is there anything I can do to help merging this in?

benjah1 avatar Sep 29 '20 00:09 benjah1

Hi, any news about this feature?

rubenqba avatar Nov 20 '20 17:11 rubenqba

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Nov 22 '20 08:11 hashicorp-cla

Any update on this feature ?

jamesarems avatar Jun 29 '21 11:06 jamesarems

Hi, any news about this feature?

way2203 avatar Sep 05 '22 07:09 way2203

I also need this merged

jsm3031 avatar Apr 20 '23 15:04 jsm3031