terraform-provider-kubernetes
terraform-provider-kubernetes copied to clipboard
feat: added "strategy.rolling_update.max_surge" attr to daemonset
Description
Enhancement: #2106
Acceptance tests
- [x] Have you added an acceptance test for the functionality being added?
- [x] Have you run the acceptance tests on this branch?
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccKubernetesDaemonSetV1_basic'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/manjinder_singh/Builds/forks/terraform-provider-kubernetes/kubernetes" -v -vet=off -run=TestAccKubernetesDaemonSetV1_basic -parallel 8 -timeout 3h
=== RUN TestAccKubernetesDaemonSetV1_basic
=== PAUSE TestAccKubernetesDaemonSetV1_basic
=== CONT TestAccKubernetesDaemonSetV1_basic
--- PASS: TestAccKubernetesDaemonSetV1_basic (4.73s)
PASS
ok github.com/hashicorp/terraform-provider-kubernetes/kubernetes 5.791s
...
Release Note
Release note for CHANGELOG:
- Updated daemonset resource to support max_surge attribute of rolling_update strategy
References
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
Quick check-in on this PR. @manjinder-mckc please take a look at our comment and let us know if you have any questions with the suggested improvement. We would love to move forward with merging. Thanks!
@iBrandyJackson @sheneska Apologies for late reply. Thank you for reviewing. I will take a look and pick this up now.
Hi @manjinder-mckc ! any help needed for this?