terraform-provider-kubernetes icon indicating copy to clipboard operation
terraform-provider-kubernetes copied to clipboard

Add "field_manager" attribute

Open jrhouston opened this issue 2 years ago • 1 comments

Description

Adds a "field_manager" attribute to the kubernetes_labels, kubernetes_annotations, and kubernetes_config_map_v1_data resources to allow configuring of the field manager name from the currently hard coded default of Terraform.

This will allow users to specify the manager name if they wish to have multiple Terraform resources that manage different fields of the same Kubernetes resource.

Fixes #1690

Acceptance tests

  • [x] Have you added an acceptance test for the functionality being added?
  • [x] Have you run the acceptance tests on this branch?

Output from acceptance testing:

TF_ACC=1 go test "/Users/john/dev/hashicorp/terraform-provider-kubernetes/kubernetes" -v -count=1 -run 'TestAccKubernetes(Labels|Annotations|ConfigMapV1Data)' -timeout 3h
=== RUN   TestAccKubernetesAnnotations_basic
--- PASS: TestAccKubernetesAnnotations_basic (29.02s)
=== RUN   TestAccKubernetesConfigMapV1Data_basic
--- PASS: TestAccKubernetesConfigMapV1Data_basic (27.20s)
=== RUN   TestAccKubernetesLabels_basic
--- PASS: TestAccKubernetesLabels_basic (27.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	84.350s

Release Note

Release note for CHANGELOG:

Add field_manager attribute

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

jrhouston avatar Sep 11 '22 19:09 jrhouston

cc @BBBmau as you will probably want to add this attribute to the kubernetes_env resource you're working on.

jrhouston avatar Sep 12 '22 18:09 jrhouston

Hi guys, pretty awesome to have the issue fixed. May I know the target due date of the next release?

awx-fuyuanchu avatar Oct 12 '22 01:10 awx-fuyuanchu

Same here, any indication on when to expect this in registry ? It's a significant blocker for us so would be greatly appreciated.

valorl avatar Oct 28 '22 14:10 valorl

It's now available in the 2.15.0 release!

LukasKnuth avatar Nov 02 '22 08:11 LukasKnuth

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Dec 03 '22 02:12 github-actions[bot]