add optional timeout to client

[jamesgoodhouse]

This adds a new argument called timeout to allow setting of the client timeout.

[daroga0002]

any progress in this?

@kmoe @bflad

[jamesgoodhouse]

I'm confused, looks like this was merged in somehow, but not from this branch... ?

[barryib]

@jamesgoodhouse I merged your PR in a fork I made for terraform-aws-modules internal usage.

You can find it here https://github.com/terraform-aws-modules/terraform-provider-http/pull/4.

Thanks for your work.

Your PR here should remain open untill it get merge.

[daroga0002]

@kmoe @bflad could you take a look?

[arianvp]

Any chance to get this merged? The diff seems completely trivial and correct to me

[hashicorp-cla]

All committers have signed the CLA.

[bflad]

Hi @jamesgoodhouse 👋 Thank you for this submission and apologies for the delayed review. This appears to have been covered by https://github.com/hashicorp/terraform-provider-http/pull/151 which required a different approach, but has recently been merged and will release with version 3.3.0 in the near future. I'm going to close this out as there does not appear to be anything actionable left to do with this pull request.

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.