terraform-provider-http icon indicating copy to clipboard operation
terraform-provider-http copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Add server certificate validation with Root CA and insecure option

Open barryib opened this issue 5 years ago • 13 comments

This PR will let user validate TLS certificate with a provided root CA or choose a insecure option with no validation at all.

May solves https://github.com/hashicorp/terraform-provider-aws/pull/11426 and have a lot of common usage.

Link for tests https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1339

barryib avatar Jan 02 '20 21:01 barryib

This would be an extremely helpful addition given the number of missing data objects in a number of the providers. (Most notably the Kubernetes provider which lacks data equivalents to almost every resource it can make) At the moment in order to work around missing Kubernetes data sources (In order to query things created with the helm provider) I have to work around the lack of TLS support by using the shell provider and using curl directly.

techdragon avatar May 05 '20 13:05 techdragon

Any chance to see this PR reviewed or at least close it if it doesn't make sense here ?

barryib avatar May 21 '20 16:05 barryib

Is there any current workaround while we wait for this to get merged?

jonatan-b-kr avatar Jun 16 '20 16:06 jonatan-b-kr

@jonatan-b-kr I had to use the shell provider and curl in order to get around this. Its not a very good workaround because of the limitations of the shell provider.

techdragon avatar Aug 27 '20 07:08 techdragon

It's almost 10 months now since this PR is open without any comment from the maintainer. Is this something we want to merge in ? If yes, how can the PR be review ? If not, please tell me so I close this PR and move on another solution.

barryib avatar Oct 05 '20 16:10 barryib

Maybe @apparentlymart could help ?

barryib avatar Oct 05 '20 19:10 barryib

It's almost 10 months now since this PR is open without any comment from the maintainer. Is this something we want to merge in ? If yes, how can the PR be review ? If not, please tell me so I close this PR and move on another solution.

@paultyng please advise.

barryib avatar Oct 06 '20 20:10 barryib

@kmoe any chance to review this PR ?

barryib avatar May 04 '21 21:05 barryib

Maybe @aareet or @bflad can review this ? I just want to know if this something hashicorp wants to add in this provider or not.

barryib avatar May 06 '21 13:05 barryib

This would be really useful if it could be merged?

stevehipwell avatar May 11 '21 06:05 stevehipwell

@aareet or @bflad is there chance to review this?

daroga0002 avatar Sep 16 '21 08:09 daroga0002

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Thierno BARRY seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Jan 28 '22 21:01 hashicorp-cla

@barryib perhaps this is still pending awaiting contribution attribution for the CLA

sbuzonas avatar Feb 28 '22 06:02 sbuzonas

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 26 '24 15:05 github-actions[bot]