Fix manifest diffs for OCI charts

[mmckeen]

Description

Fixes https://github.com/hashicorp/terraform-provider-helm/issues/1325.

The OCI registry client wasn't properly initialized in this code path for OCI charts.

This also changes error handling so failures to fetch the chart aren't silent in the future.

Acceptance tests

• [X] Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

NONE

References

https://github.com/hashicorp/terraform-provider-helm/issues/1325

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[hashicorp-cla]

All committers have signed the CLA.

[sheneska]

Hi @mmckeen, Thank you for your interest in contributing to this provider. I would like to approve and merge your change, however, two things are missing:

• Sign the CLA
• Add a change log entry

Please let me know once this is done & feel free to ask any questions.

[mmckeen]

Hey @sheneska 👋

I went ahead and signed the CLA and added a CHANGELOG entry.

Let me know if there's anything else for this 🙇.

Thank you!

[sbeginCoveo]

@sheneska What's the release cycle like for the helm provider?