terraform-provider-google icon indicating copy to clipboard operation
terraform-provider-google copied to clipboard

Add "log check failures" boolean option to `google_monitoring_uptime_check_config`

Open georgecrawford opened this issue 4 years ago • 5 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

google_monitoring_uptime_check_config allows me to create an Uptime Check with Terraform and see it at https://console.cloud.google.com/monitoring/uptime. However there is no option listed in the Terraform arguments/attributes to match the option to Log check failures which I see when creating/editing an uptime check in the UI:

2021:01:28-16 10 35

New or Affected Resource(s)

  • google_monitoring_uptime_check_config

Potential Terraform Configuration

resource "google_monitoring_uptime_check_config" "http" {
  display_name        = "http-uptime-check"
  timeout             = "60s"
  log_check_failures  = true # new field added here

  http_check {
    path = "/some-path"
    port = "8010"
    request_method = "POST"
    content_type = "URL_ENCODED"
    body = "Zm9vJTI1M0RiYXI="
  }

  monitored_resource {
    type = "uptime_url"
    labels = {
      project_id = "my-project-name"
      host       = "192.168.1.1"
    }
  }

  content_matchers {
    content = "example"
  }
}

References

georgecrawford avatar Jan 28 '21 16:01 georgecrawford

NB: I've also logged this in the (I think?) upstream REST API project: https://github.com/googleapis/nodejs-monitoring/issues/517

georgecrawford avatar Jan 28 '21 16:01 georgecrawford

This flag could also help us a lot. Is there any update on it?

wi1dcard avatar Oct 08 '21 00:10 wi1dcard

is there any updates? if not , is there any work around?

ghada-mahmod avatar May 25 '22 03:05 ghada-mahmod

b/245957600

melinath avatar Sep 09 '22 17:09 melinath

This feature is currently blocked by https://github.com/googleapis/nodejs-monitoring/issues/517 which was correctly identified by @georgecrawford I have set this as a blocker internally for now

NA2047 avatar Sep 13 '22 17:09 NA2047

Will this be added anytime soon? Thanks!

miguelangelmorenochacon avatar Jan 18 '23 11:01 miguelangelmorenochacon

Is there an update on this?

roberth1988 avatar Jul 08 '24 12:07 roberth1988