terraform-provider-google icon indicating copy to clipboard operation
terraform-provider-google copied to clipboard

Failing test(s): TestAccComputeNetworkFirewallPolicyRule_multipleRules

Open c2thorn opened this issue 1 year ago • 1 comments

Impacted tests

  • TestAccComputeNetworkFirewallPolicyRule_multipleRules

Affected Resource(s)

  • google_compute_network_firewall_policy_rule

Failure rates

  • 100% since 2024-08-15

Message(s)

        Error: Error updating NetworkFirewallPolicy "projects/<project>/global/firewallPolicies/<name>": googleapi: Error 412: Invalid fingerprint., conditionNotMet

Nightly build test history

  • https://hashicorp.teamcity.com/test/3924032820256974661?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS&expandTestHistoryChartSection=true

c2thorn avatar Aug 21 '24 22:08 c2thorn

skipping in VCR: https://github.com/GoogleCloudPlatform/magic-modules/pull/11522

c2thorn avatar Aug 22 '24 00:08 c2thorn

Hi c2thorn, I cannot reproduce it - I checked out the latest terraform-provider-google and run:

make testacc TEST=./google/services/compute TESTARGS='-run=TestAccComputeNetworkFirewallPolicyRule_multipleRules'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/compute -v -run=TestAccComputeNetworkFirewallPolicyRule_multipleRules -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeNetworkFirewallPolicyRule_multipleRules
=== PAUSE TestAccComputeNetworkFirewallPolicyRule_multipleRules
=== CONT  TestAccComputeNetworkFirewallPolicyRule_multipleRules
--- PASS: TestAccComputeNetworkFirewallPolicyRule_multipleRules (153.64s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/compute  153.792s

In the logs I see rules successfully created/updated.

There's also no acctest.SkipIfVcr(t) in the TestAccComputeNetworkFirewallPolicyRule_multipleRules added in this PR https://github.com/GoogleCloudPlatform/magic-modules/pull/11522

I don't have access to https://hashicorp.teamcity.com/test/3924032820256974661?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS&expandTestHistoryChartSection=true - Can you verify if this test still fails there?

mihhalj avatar Jan 24 '25 10:01 mihhalj

Thank you for checking @mihhalj, it looks like this started passing late last year. I will close.

c2thorn avatar Jan 24 '25 18:01 c2thorn

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Feb 24 '25 02:02 github-actions[bot]