terraform-provider-google icon indicating copy to clipboard operation
terraform-provider-google copied to clipboard

Apply new labels model to resources

Open zli82016 opened this issue 2 years ago • 11 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In the next major release, apply the new labels model to resources by using the type KeyValueLabels

  • labels field in google_edgenetwork_network
  • labels field in google_edgenetwork_subnet

zli82016 avatar Oct 11 '23 18:10 zli82016

I'd say this is comparable to #1672. It's a very reasonable feature request, but would entail more involved client-side logic than we usually include in this library, which is a fairly thin client. I'll raise internally whether this can be prioritized.

tritone avatar Nov 19 '20 03:11 tritone

@tritone Can you please ask internally about the similar request to add this in google-cloud-ruby as well?

googleapis/google-cloud-ruby#8147

quartzmo avatar Nov 19 '20 19:11 quartzmo

@tritone Any update as to whether or not this feature can be prioritized?

quartzmo avatar Jan 13 '21 19:01 quartzmo

@quartzmo I don't think we are prioritizing this in the next quarter at least. @frankyn may have more context for Ruby specifically.

tritone avatar Jan 22 '21 22:01 tritone

We are not yet prioritizing this work across languages. It's still in our backlog, and we are working our way back to it.

frankyn avatar Jan 22 '21 22:01 frankyn

@frankyn why you don't want implement it?

Slach avatar Oct 25 '23 16:10 Slach

We do, but it's competing with other work items don't have ETA yet. Thanks for your patience.

frankyn avatar Oct 25 '23 20:10 frankyn

Just wanted to provide a long-delayed update here. We're planning on implementing parallel upload and download features in the newly-created subpackage transfermanager. We did the initial merge for downloads this week, more download features are coming later this month, and uploads should be coming in the second half of the year most likely. Feel free to take a look here: https://pkg.go.dev/cloud.google.com/go/[email protected]/transfermanager ; we are open to hearing feedback.

tritone avatar Jun 05 '24 17:06 tritone

@tritone great news, hope you will update this issue when Uploader will implements

Slach avatar Jun 05 '24 17:06 Slach

Hi, @tritone, I am rather interested in this feature, so since it's been few months since last update just wanted to as, maybe you know if it is currently scheduled or some ETA is assigned? Thanks.

Vytenis-Valutkevicius avatar Oct 18 '24 06:10 Vytenis-Valutkevicius

Hi @tritone, we're also very interested in Go support for this feature! Just wanted to ask when you think it might be ready for production use? Thanks!

begelundmuller avatar Mar 04 '25 12:03 begelundmuller

Base on https://pkg.go.dev/cloud.google.com/go/storage/transfermanager and https://github.com/googleapis/google-cloud-go/tree/storage/v1.51.0/storage/transfermanager I guess it is already released and ready for use?

pingleiwandb avatar Apr 21 '25 03:04 pingleiwandb