terraform-provider-consul icon indicating copy to clipboard operation
terraform-provider-consul copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

prepared query: add missing RemoveEmptyTag and Name should be optional

Open ygersie opened this issue 2 years ago • 2 comments

  • The Name field of the JSON payload should be optional, see: https://www.consul.io/api-docs/query#name
  • Add missing https://www.consul.io/api-docs/query#removeemptytags

ygersie avatar Jul 22 '22 13:07 ygersie

Hi @ygersie, thanks for opening this PR. The API client will first need to be updated at https://github.com/hashicorp/consul before I can merge this. I will look into this.

remilapeyre avatar Jul 24 '22 22:07 remilapeyre

Hi @ygersie! I opened https://github.com/hashicorp/consul/pull/14244 to add this to the Consul API client. Once it is merge we will be able to add support for this in the provider.

remilapeyre avatar Aug 17 '22 21:08 remilapeyre

@remilapeyre is there any chance this can get a push?

ygersie avatar Jan 10 '23 10:01 ygersie

Looks like the required changes got merged in https://github.com/hashicorp/consul/pull/16113, I think this should now be doable :) @remilapeyre

LukasdeBoer avatar May 12 '23 13:05 LukasdeBoer