azurerm_windows_virtual_machine: added NvmeDisk for diff_disk_settings/placement

[eltimmo]

Community Note

• Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added NvmeDisk option for diff_disk_settings/placement. Added test

PR Checklist

• [x] I have followed the guidelines in our Contributing Documentation.
• [x] I have checked to ensure there aren't other open Pull Requests for the same update/change.
• [x] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• [x] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• [x] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work. For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• [x] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• [x] I have written new tests for my resource or datasource changes & updated any relevant documentation.
• [x] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

• [ ] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

make acctests SERVICE='compute' TESTARGS='-run=TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk' TESTTIMEOUT='10m'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/compute -run=TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk -timeout 10m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk
=== PAUSE TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk
=== CONT  TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk
--- PASS: TestAccWindowsVirtualMachine_diskOSEphemeralNVMeDisk (248.86s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       250.291s

For state migrations please test the changes locally and provide details here, such as the versions involved in testing the migration path. For further details on testing state migration changes please see our guide on state migrations in the contributor documentation. -->

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_windows_virtual_machine - support for the NvmeDisk option for the diff_disk_settings/placement setting. [GH-29670]

This is a (please select all that apply):

• [ ] Bug Fix
• [x] New Feature (ie adding a service, resource, or data source)
• [ ] Enhancement
• [ ] Breaking Change

Related Issue(s)

Fixes #29670

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

[!NOTE] If this PR changes meaningfully during the course of review please update the title and description as required.