terraform-provider-azurerm icon indicating copy to clipboard operation
terraform-provider-azurerm copied to clipboard

New Resource: `azurerm_network_manager_routing_rule_collection`

Open teowa opened this issue 5 months ago • 1 comments

Community Note

  • Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New Resource: azurerm_network_manager_routing_rule_collection

PR Checklist

  • [x] I have followed the guidelines in our Contributing Documentation.
  • [x] I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • [x] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • [x] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • [x] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work. For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • [x] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • [x] I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • [x] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • [ ] (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • [x] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Resource: azurerm_network_manager_routing_rule_collection [GH-00000]

This is a (please select all that apply):

  • [ ] Bug Fix
  • [x] New Feature (ie adding a service, resource, or data source)
  • [ ] Enhancement
  • [ ] Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

[!NOTE] If this PR changes meaningfully during the course of review please update the title and description as required.

teowa avatar Jun 03 '25 07:06 teowa

Hi, @ms-zhenhua , thanks for reviewing this! I have updated the code, please kindly take another look, thanks.

teowa avatar Jun 20 '25 00:06 teowa

Any update on this PR? Would be amazing having this in the v4.37.0 milestone.

nduijvelshoff avatar Jul 16 '25 18:07 nduijvelshoff

image

teowa avatar Jul 28 '25 07:07 teowa

Hi @sreallymatt , thanks for reviewing! I have updated the code, please kindly take another look. image

teowa avatar Aug 13 '25 11:08 teowa

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Sep 14 '25 02:09 github-actions[bot]