terraform-provider-azurerm
terraform-provider-azurerm copied to clipboard
fix(26428): data azurerm_network_service_tags AzureFrontDoor.Frontend support
Community Note
- Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
- Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review
Description
Added support for service
with .
(like AzureFrontDoor.Frontend
)
PR Checklist
- [x] I have followed the guidelines in our Contributing Documentation.
- [x] I have checked to ensure there aren't other open Pull Requests for the same update/change.
- [x] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
- [x] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
- [x] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”
Changes to existing Resource / Data Source
- [x] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
- [x] I have written new tests for my resource or datasource changes & updated any relevent documentation.
- [x] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
- [x] (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.
Testing
- [x] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
$ make acctests SERVICE='network' TESTARGS='-run=TestAccDataSourceAzureRMServiceTags_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccDataSourceAzureRMServiceTags_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccDataSourceAzureRMServiceTags_basic
=== PAUSE TestAccDataSourceAzureRMServiceTags_basic
=== RUN TestAccDataSourceAzureRMServiceTags_tagName
=== PAUSE TestAccDataSourceAzureRMServiceTags_tagName
=== RUN TestAccDataSourceAzureRMServiceTags_region
=== PAUSE TestAccDataSourceAzureRMServiceTags_region
=== RUN TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== RUN TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== RUN TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
=== RUN TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== CONT TestAccDataSourceAzureRMServiceTags_basic
=== CONT TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== CONT TestAccDataSourceAzureRMServiceTags_region
=== CONT TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== CONT TestAccDataSourceAzureRMServiceTags_tagName
=== CONT TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== CONT TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
--- PASS: TestAccDataSourceAzureRMServiceTags_basic (27.74s)
--- PASS: TestAccDataSourceAzureRMServiceTags_region (41.33s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend (84.89s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty (93.53s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoor (102.18s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend (111.46s)
--- PASS: TestAccDataSourceAzureRMServiceTags_tagName (148.55s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/network 148.566s
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
-
azurerm_network_service_tags
-data
support forAzureFrontDoor.Backend
,AzureFrontDoor.FirstParty
andAzureFrontDoor.Frontend
tags
This is a (please select all that apply):
- [x] Bug Fix
- [ ] New Feature (ie adding a service, resource, or data source)
- [ ] Enhancement
- [ ] Breaking Change
Related Issue(s)
Fixes #26428