terraform-provider-azurerm icon indicating copy to clipboard operation
terraform-provider-azurerm copied to clipboard

`storage`: refactoring to use `hashicorp/go-azure-sdk`

Open tombuildsstuff opened this issue 1 year ago • 1 comments

This PR refactors the azurerm_storage_account Data Source and Resource and the azurerm_storage_account_network_rules Resource over to using hashicorp/go-azure-sdk.

This PR supersedes #23002 by @petr-stupka, since the base layer used in that PR is no longer used (and therefore the logic in it will no longer work) - and also supersedes #25789 by @wuxu92, since that’s only related to the Static Website endpoint. However this PR fixes #23240, #22992, #19055, #18897 and #15609 (which both were trying to fix in slightly different manners) by polling during the creation of the Storage Account, when applicable, for each type of supported sub-service (e.g. Blobs, Files, Static Websites etc) using a custom poller.

This also fixes #25160 and #12627 by switching to use hashicorp/go-azure-sdk’s base layer, which’ll correctly surface errors coming from the Azure API.

Fixes #25160 Fixes #23240 Fixes #22992 Fixes #22507 Fixes #19427 Fixes #19055 Fixes #18897 Fixes #15609 Fixes #14737 Fixes #12627 Fixes #26389


Changelog

(TBD)

tombuildsstuff avatar Jun 04 '24 15:06 tombuildsstuff

@tombuildsstuff Any chance I can get you to look at this PR ? I've been hitting this consistently while creating new storage accounts and I can't figure if its my setup or azure or the provider that is the problem.

sharninder-se avatar Jun 18 '24 10:06 sharninder-se

Any update on the timeline for this fix?

krapgras avatar Jul 08 '24 11:07 krapgras

Test results:

CDN

Screenshot 2024-07-18 at 21 25 40

Compute

failures are 4.0 related

Screenshot 2024-07-18 at 21 25 46

Storage

Screenshot 2024-07-18 at 21 36 47 Screenshot 2024-07-18 at 21 37 47

remaining failures are 4.0 related

Screenshot 2024-07-18 at 21 38 15

manicminer avatar Jul 18 '24 20:07 manicminer

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Aug 18 '24 02:08 github-actions[bot]