New Resource: `azurerm_system_center_virtual_machine_manager_cloud`

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource System Center Virtual Machine Manager Cloud in SCVMM RP. Maybe these three PRs (https://github.com/hashicorp/terraform-provider-azurerm/pull/25449, https://github.com/hashicorp/terraform-provider-azurerm/pull/25451, https://github.com/hashicorp/terraform-provider-azurerm/pull/25429) need to be merged one by one.

Change Log

• azurerm_system_center_virtual_machine_manager_cloud - support this new resource

This is a (please select all that apply):

• [ ] Bug Fix
• [x] New Feature (ie adding a service, resource, or data source)
• [ ] Enhancement
• [ ] Breaking Change

Test Result

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (406.70s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (269.70s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (326.31s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (592.14s)

References

Azure doc REST API specs

[rcskosir]

@neil-yechenwei :wave: I know this is currently a draft, but when it is ready for review can you please add in the new PR template? The extra information in the template helps with the review process and for traceability in the future for our users about what this change did.

[neil-yechenwei]

Thanks for the suggestion. I updated PR description.

[neil-yechenwei]

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (685.99s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (572.06s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (278.06s) --- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (568.63s)

[neil-yechenwei]

@catriona-m , thanks for the comment. Please take another look.

[neil-yechenwei]

@jackofallops , thanks for the comment. Please take another look.

[neil-yechenwei]

Thanks for the comment. Please take another look.

[neil-yechenwei]

@katbyte , I noticed that the PR to add stateRefreshFunc has been merged. So I updated this PR to remove the time sleep accordingly. Below is the test result I just now triggered.

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (540.31s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (332.87s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (391.18s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (779.31s)

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.