`azurerm_container_registry` - Avoid unnecessary recreate when georeplication.tags update

[magodo]

This PR fixes two things:

• The first commit fixes some problematic code introduced in https://github.com/hashicorp/terraform-provider-azurerm/pull/15340, where those code only handles v2.0 correctly, but are meaningless for v3.0
• The second commit fixes https://github.com/hashicorp/terraform-provider-azurerm/issues/24960, where the georeplication's zone redundency enabled flag is checked by pointer, instead of value,to tell whether a recreate of those georeplications are needed.

[magodo]

Hi @catriona-m, this is not an issue introduced by this PR, as if you switch the order of the ARM_TEST_LOCATION_ALT and ARM_TEST_LOCATION_ALT2, it shall pass.

You can find the details here: https://github.com/hashicorp/terraform-provider-azurerm/issues/17987#issuecomment-1216095257.

[catriona-m]

Hi @catriona-m, this is not an issue introduced by this PR, as if you switch the order of the ARM_TEST_LOCATION_ALT and ARM_TEST_LOCATION_ALT2, it shall pass.

You can find the details here: #17987 (comment).

Thanks for explaining @magodo. Would it make sense to fix those tests as part of this PR?

[magodo]

@catriona-m Sure, I've updated the test and verified that both order of the locations pass the test locally.

[magodo]

@stephybun I have no idea... I tried to run it locally and on teamcity, with the same setting as the failing test case, all passed:

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.