terraform-provider-azurerm icon indicating copy to clipboard operation
terraform-provider-azurerm copied to clipboard

certificate_id an optional argument of azurerm_container_app resource

Open harshavmb opened this issue 1 year ago • 5 comments

This fixes #24110

Current azurerm_container_app resource has ingress block which has custom_domain which mandates certificate_id to be a required field even when certificate_binding_type set to Disabled by default. This contradicts with the documentation here for Azure managed certificates.

This PR aims to set certificate_id as Optional & only required when certificate_binding_type set to SniEnabled.

harshavmb avatar Dec 05 '23 08:12 harshavmb

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

github-actions[bot] avatar Jan 15 '24 06:01 github-actions[bot]

I waiting for this feature to be merged to fix my terraform code ( related with issue https://github.com/hashicorp/terraform-provider-azurerm/issues/24110 ).

caiola avatar Feb 06 '24 11:02 caiola

I'd also like to see this merged asap.

jk-f5 avatar Feb 09 '24 21:02 jk-f5

@tombuildsstuff Can this move forward?

jpmicrosoft avatar Feb 13 '24 15:02 jpmicrosoft

noticed #24421 might replace this functionality so going to leave this till that PR is reviewed

katbyte avatar Feb 28 '24 16:02 katbyte

Hi @harshavmb - Thanks for this PR. This block has been deprecated due to a circular reference problem and replaced with a new resource azurerm_container_app_custom_domain. We're investigating the support of the Azure Managed Certificates in that resource at the moment, so I'm going to close this PR for now. Please follow #25356 for progress.

Thanks

jackofallops avatar Mar 22 '24 06:03 jackofallops

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Apr 22 '24 02:04 github-actions[bot]