terraform-provider-azurerm
terraform-provider-azurerm copied to clipboard
certificate_id an optional argument of azurerm_container_app resource
This fixes #24110
Current azurerm_container_app
resource has ingress
block which has custom_domain
which mandates certificate_id
to be a required field even when certificate_binding_type
set to Disabled
by default. This contradicts with the documentation here for Azure managed certificates.
This PR aims to set certificate_id
as Optional
& only required when certificate_binding_type
set to SniEnabled
.
This PR is being labeled as "stale" because it has not been updated for 30 or more days.
If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.
If you need some help completing this PR, please leave a comment letting us know. Thank you!
I waiting for this feature to be merged to fix my terraform code ( related with issue https://github.com/hashicorp/terraform-provider-azurerm/issues/24110 ).
I'd also like to see this merged asap.
@tombuildsstuff Can this move forward?
noticed #24421 might replace this functionality so going to leave this till that PR is reviewed
Hi @harshavmb - Thanks for this PR. This block has been deprecated due to a circular reference problem and replaced with a new resource azurerm_container_app_custom_domain
. We're investigating the support of the Azure Managed Certificates in that resource at the moment, so I'm going to close this PR for now. Please follow #25356 for progress.
Thanks
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.