terraform-provider-azurerm icon indicating copy to clipboard operation
terraform-provider-azurerm copied to clipboard

azurerm_application_gateway - support [globalConfiguration]

Open ms-zhenhua opened this issue 2 years ago • 2 comments

fix https://github.com/hashicorp/terraform-provider-azurerm/issues/17627 image

ms-zhenhua avatar Jul 16 '22 04:07 ms-zhenhua

Hi @katbyte, thank you for reviewing my code. I have resolved the comments and rerun the testcase. Kindly help review it again.

ms-zhenhua avatar Aug 10 '22 13:08 ms-zhenhua

@katbyte @ms-zhenhua i recommend reverting the name change of global_configuration -> global. i appreciate the desire to remove redundancy in names. i recommend we consider the fact that this name is established by ARM. and that there is already a convention in this resource to match the ARM names. i personally find it useful when hopping between the two. https://docs.microsoft.com/en-us/azure/templates/microsoft.network/applicationgateways?tabs=bicep&pivots=deployment-language-bicep#resource-format

the name global_configuration matches the nomenclature used by Azure resource manager (globalConfiguration). it also matches the convention established by other *_configurations, such as frontend_ip_configuration (frontendIPConfiguration in ARM)

using the name global_configuration keeps the naming consistent with ARM and consistent within this resource

markwaddle avatar Aug 11 '22 16:08 markwaddle

This functionality has been released in v3.19.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Aug 23 '22 15:08 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Sep 23 '22 02:09 github-actions[bot]