azurerm_machine_learning_compute_cluster : Fix case sensitivity of vm_size property causing resource re-creation issue

[sinbai]

Fix issue #17562.

[tombuildsstuff]

hi @sinbai

Taking a look into this one, it appears that the vm_size shouldn't become case-insensitive here, but instead (since the API is returning this in upper-case), this should be specified in the Terraform Configuration (and validated within the Schema) in upper-case.

As such, whilst I'd agree with @stephybun that we should file an issue on the Swagger repository, we should also file an issue requesting that the possible values for this field are documented in the Swagger - since there's a fixed set of values possible for this API.

Thanks!

[sinbai]

Could we raise an issue for this in Azure/azure-rest-api-specs and leave a comment in the code linking to it?

@stephybun thanks for your feedback. I have filed an Api issue #20216 to track it.

[sinbai]

hi @sinbai

Taking a look into this one, it appears that the vm_size shouldn't become case-insensitive here, but instead (since the API is returning this in upper-case), this should be specified in the Terraform Configuration (and validated within the Schema) in upper-case.

As such, whilst I'd agree with @stephybun that we should file an issue on the Swagger repository, we should also file an issue requesting that the possible values for this field are documented in the Swagger - since there's a fixed set of values possible for this API.

Thanks!

@tombuildsstuff thanks for your suggestion here. I have submitted an https://github.com/Azure/azure-rest-api-specs/issues/20217 to request the possible values of AmlCompute vmSize.

[katbyte]

@sinbai - it looks like the swagger issue was incorrectly closed as won't fix, could you please follow up with that?

[sinbai]

@sinbai - it looks like the swagger issue was incorrectly closed as won't fix, could you please follow up with that?

Sure, done.

[tombuildsstuff]

@sinbai since this PR is blocked on the upstream Swagger Issue I'm going to close this PR temporarily until the upstream issue is resolved, but when that's fixed we can reopen this and take another look here.

Thanks!

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.