terraform-provider-azuread icon indicating copy to clipboard operation
terraform-provider-azuread copied to clipboard

Prevent Duplicate Group Names by Default

Open glasko-dp opened this issue 3 years ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

prevent_duplicate_names = false does not seem to be the sane choice for default here; as overlooking this property and omitting it can result in many duplicate resources being unintentionally created, whereas if the default were true, unintentionally missing it would prompt the user to make a deliberate choice to create the duplicate resources.

New or Affected Resource(s)

  • azuread_group

Potential Terraform Configuration

resource "azuread_group" "testGroup" {
  display_name       = "testGroup"
  security_enabled   = true
  assignable_to_role = true
}

References

  • #0000

glasko-dp avatar Oct 27 '22 16:10 glasko-dp

Hi @glasko-dp, thanks for suggesting this. Changing the default here potentially makes a lot of sense, although as this would e a breaking change to the provider, we'd only be able to do this in the next major version (which currently will be v3.0).

I've assigned this to the v3.0 milestone for consideration when we get closer to that version.

manicminer avatar Oct 27 '22 18:10 manicminer