principal_type_data_source - Feature - issue #824

[Threpio]

https://github.com/hashicorp/terraform-provider-azuread/issues/824

[Threpio]

Most of the comments have been applied and committed -Sorry for the horrible commit mess.

I am not sure that I have handled the directoryObject object properly now that I have changed it to a pointer from the client.Get function.

I will work on the tests asap.

[manicminer]

@Threpio Thanks, I'll take another look once the tests are pushed. Don't worry about the commit history, we can squash it :)

[Threpio]

Tests have been added -I cannot apply the last suggestion as it is outdated and yet not updated.

For the tests I have done 3 success cases - I do not see examples of failing to terraform configuration being used for different unit tests and so have not written these. The docs are linted but the content might need a 5-minute review.

[github-actions[bot]]

This functionality has been released in v2.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.