User(s) Data Source: Lookup users by on-prem SAM account

[daramir]

This PR extends the features on User and Users Data Sources, by adding support to look up users by on-premise SAM account name.

• Add on-prem SAM account name as supported arguments In Data Sources: User and Users documentation.
• Creates Tests on User and Users Data Sources for validating support of on-prem SAM account names as reference arguments. Data source should be able to search users by on-prem SAM account name, the same way it's possible than by UPN or mail nickname.
• Refactor of DS Read method for both data sources.
• Users data source also exports onpremises_sam_account_names.

Note: Haven't confirmed the status of the tests, please advice if correct and complete. The value for the on-prem SAM account name for the test users is unknown to me.

[manicminer]

Hi @daramir, many thanks for working on this! This is definitely a feature we'd like to add, although at this time we don't have a way to test this. I'm looking at improving our testing setup to include a tenant with AD Connect and once this is done, we'll be in a position to look at merging this.

[patrickmarabeas]

@manicminer what's the timeline on testing improvements?

[daramir]

Hi @manicminer , just checking in to echo Patrick's question. Do you have a broad timeline for the testing setup with AD connect? Kind regards

[manicminer]

We don't have a timeline at the moment, my best guess with current priorities is in the order of several weeks. Once we have a workable test environment I'll get back on this straight away.

[daramir]

Hi @manicminer , could you please provide us with an updated timeline for the test env to be set up?

[patrickmarabeas]

Hey @manicminer, just following up on the current state of this...

[patrickmarabeas]

@manicminer giving this one a bump...