terraform-provider-azuread icon indicating copy to clipboard operation
terraform-provider-azuread copied to clipboard
verified publisher icon hashicorp

fix: allow aad group to be recreated when prevent_duplicate_names is true

Open josh-barker opened this issue 3 years ago • 2 comments

This PR replicates the bug as described in #697

It also shows a potential way to overcome the bug, but there may be a better way to achieve it.

josh-barker avatar Dec 16 '21 00:12 josh-barker

Hi @josh-barker, sorry for the delay in reviewing this. Thanks for the implementation, I think this is on the right track but I'm concerned about making decisions based on the RawState as this could have unintended side effects. You're right, there are no Plugin SDK helpers that can expose this right now, but I think the best course would be to send this upstream so I'll work on a PR for https://github.com/hashicorp/terraform-plugin-sdk to expose whether a diff involves a ForceNew - I think this is possible based on the data held in the raw diff.

manicminer avatar Jan 13 '22 12:01 manicminer

Hey @manicminer, no worries. 👍🏻 Yep, that sounds like a great idea. :-)

josh-barker avatar Jan 13 '22 23:01 josh-barker

Is there any update on the upstream change or this PR?

ccadruvi avatar Dec 07 '22 15:12 ccadruvi

Superceded by #980

manicminer avatar Jan 18 '23 17:01 manicminer

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Feb 19 '23 02:02 github-actions[bot]