terraform-provider-azuread icon indicating copy to clipboard operation
terraform-provider-azuread copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

[WIP] IdentityGovernance Package (accessPackages / EntitlementMangement)

Open kaovd opened this issue 3 years ago • 11 comments

There is a lot of various sub resources in the Identity Governance scope - currently WIP on EntitlementManagement / accessPackages here specifically and introducting the package as it does not exist yet

Closes #547

kaovd avatar Oct 02 '21 21:10 kaovd

@kaovd , are you still actively working on this PR? We have a need for it and we're looking at picking up your WIP and trying to complete it.

askew avatar Mar 17 '22 10:03 askew

@kaovd , are you still actively working on this PR? We have a need for it and we're looking at picking up your WIP and trying to complete it.

Will push my latest commit, had a bit of a hiatus for past month, just a few bugs left I hope 😄

kaovd avatar Mar 17 '22 10:03 kaovd

thank you for your work! we're eagerly waiting for this one to be merged 🙏

aleksei-aikashev avatar Apr 28 '22 00:04 aleksei-aikashev

@aleksei-aikashev I plan to try and revisit this in coming weeks, I did kind of expect someone to pick this up and fix the remaining bugs but will give it another go

kaovd avatar May 06 '22 08:05 kaovd

@kaovd, we have done a fair amount of work on this and have a WIP in the entitlement-management branch of my fork. It would be good to work with you to get these changes merged into this PR.

askew avatar May 12 '22 11:05 askew

@kaovd, we have done a fair amount of work on this and have a WIP in the entitlement-management branch of my fork. It would be good to work with you to get these changes merged into this PR.

Thank you! I will take a look today

kaovd avatar May 12 '22 15:05 kaovd

@askew Thanks for some of these fixes - Just one the ConnectedOrganisations resource / Client you've added - I don't see where msgraph.ConnectedOrganization is defined in the SDK unless you've referenced something else locally?

kaovd avatar May 12 '22 17:05 kaovd

It's dependent on the upstream change to the Hamilton library https://github.com/manicminer/hamilton/pull/156

askew avatar May 12 '22 18:05 askew

Ah ok, forgot to check the drafts - also some enums where missing that would be good to get in the same PR on access package assignment question types (TextInputQuestion, MultipleChoiceQuestion)

kaovd avatar May 12 '22 19:05 kaovd

any updates on this? 🙏

aleksei-aikashev avatar Jun 15 '22 01:06 aleksei-aikashev

any updates on this? 🙏

We are blocked on https://github.com/manicminer/hamilton/pull/156 as we are still waiting for the maintainer to be able to obtain an appropriate test environment to run the build pipeline and tests - once its done I can pull in and take out of draft

kaovd avatar Jun 22 '22 13:06 kaovd

a bit surprised that I missed this one before starting my work in #903 , anyway raised another one for the implementation there.

stanleyz avatar Oct 07 '22 20:10 stanleyz

Ditching this one in favour of https://github.com/hashicorp/terraform-provider-azuread/pull/903

kaovd avatar Nov 10 '22 15:11 kaovd

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Dec 11 '22 02:12 github-actions[bot]