terraform-provider-awscc icon indicating copy to clipboard operation
terraform-provider-awscc copied to clipboard

docs: add example for: awscc_controltower_enabled_control

Open gokendra1 opened this issue 11 months ago • 1 comments

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates OR Closes #0000

gokendra1 avatar Mar 22 '24 11:03 gokendra1

@Gokendra , thank you for your contribution.

instead of adding the md file directly, could you use the .md.tmpl template file instead

you can find example of similar pull request here: https://github.com/hashicorp/terraform-provider-awscc/pull/1343/files

wellsiau-aws avatar Mar 28 '24 02:03 wellsiau-aws

@Gokendra , thank you for your contribution.

instead of adding the md file directly, could you use the .md.tmpl template file instead

you can find example of similar pull request here: https://github.com/hashicorp/terraform-provider-awscc/pull/1343/files

@wellsiau-aws Thank you for sharing your valuable feedback. I have now updated the code according to your suggestions. Could you please review it?

gokendra1 avatar Apr 08 '24 06:04 gokendra1

minor tweak requested, please have a look

Thank you for your additional suggestion :)

gokendra1 avatar Apr 08 '24 17:04 gokendra1

@gokendra1 Thank you for the contribution!

marcosentino avatar Apr 09 '24 13:04 marcosentino