terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

feat: Add manual_creation argument to aws_codebuild_webhook resource

Open phuhung273 opened this issue 1 year ago • 7 comments

Description

  • Add manual_creation argument to aws_codebuild_webhook resource

Relations

Closes #40078

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCodeBuildWebhook_manualCreation PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildWebhook_manualCreation'  -timeout 360m
2024/11/17 14:21:30 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildWebhook_manualCreation
=== PAUSE TestAccCodeBuildWebhook_manualCreation
=== CONT  TestAccCodeBuildWebhook_manualCreation
--- PASS: TestAccCodeBuildWebhook_manualCreation (45.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  46.059s

phuhung273 avatar Nov 17 '24 07:11 phuhung273

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Nov 17 '24 07:11 github-actions[bot]

Any updates on getting this merged in?

kieran-lowe avatar Jan 06 '25 10:01 kieran-lowe

Any updates on getting this merged in?

Im still waiting for maintainer review. Let's be patient, just a very beginning of the year.

phuhung273 avatar Jan 06 '25 11:01 phuhung273

Any updates here?

avidspartan1 avatar Mar 07 '25 20:03 avidspartan1

Hey, @jar-b - apologies in advance for direct pinging you. How can we move this PR forward? Do we just need to continue waiting and someone will get to it eventually?

avidspartan1 avatar Apr 01 '25 11:04 avidspartan1

Hey @avidspartan1 - our current focus is on items for the V6 major release. Once that is GA we'll return to reviewing enhancements based on the prioritization guide linked in the comments above.

jar-b avatar Apr 01 '25 14:04 jar-b

Thanks, Jared. I thought I'd read all of the contributing guidelines, but I missed the prioritization FAQ. Sorry!

avidspartan1 avatar Apr 01 '25 15:04 avidspartan1

Thanks @ewbankkit so much for your commits. Also @avidspartan1 @jar-b for your support.

phuhung273 avatar Apr 15 '25 12:04 phuhung273

@phuhung273 Thanks for the contribution :tada: :clap:.

ewbankkit avatar Apr 15 '25 16:04 ewbankkit

[!WARNING] This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] avatar Apr 15 '25 16:04 github-actions[bot]

This functionality has been released in v5.95.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Apr 17 '25 22:04 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 18 '25 02:05 github-actions[bot]