terraform-provider-aws
terraform-provider-aws copied to clipboard
fix: no longer require ExactlyOneOf web_identity_token or web_identity_token_file in provider config
Description
ExactlyOneOf does not permit the usage of the AWS_WEB_IDENTITY_TOKEN_FILE environment variable, but web_identity_token and web_identity_token_file do conflict with each other. Switch to ConflictsWith to prevent that conflict while still not explicitly requiring one of either to be set.
Relations
Closes #37401
References
Provider configuration docs covering assume role with web identity
Output from Acceptance Testing
% make testacc TESTS=TestAccXXX PKG=ec2
...
Community Note
Voting for Prioritization
- Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
- Please see our prioritization guide for information on how we prioritize.
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
For Submitters
- Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
- For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
- Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.
Could I get some clarification on what acceptance tests I would need to run for this change?
Thanks for the PR, @derekheld
Could I get some clarification on what acceptance tests I would need to run for this change?
It looks like we don't have any tests around this particular parameter
Thanks for the PR, @derekheld
Could I get some clarification on what acceptance tests I would need to run for this change?
It looks like we don't have any tests around this particular parameter
Well that would explain why I was having a hard time finding one 😅
I apologize, this is not just my first time contributing to this project but also my first time doing any development in Go. A lot of learning for me to do.
I apologize, this is not just my first time contributing to this project but also my first time doing any development in Go. A lot of learning for me to do.
Nothing to apologize for! Everyone has to start somewhere. Go is known for its opinionated formatting, and we have a bunch of automated style checks on top of that