terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

feat: kendra data source template

Open DavidTanner opened this issue 1 year ago • 3 comments

Description

Following a comment from #29922 I have added a template configuration to the provider. I don't have much time developing in Golang, and didn't find a way to import an object with no pre-defined structure.

The template_configuration is an optional field, so should only be an enhancement and not break any existing configurations.

Relations

Relates #29922

References

TemplateConfiguration:

Create Data Source API Request Syntax

TemplateConfiguration

Template

Output from Acceptance Testing

% make testacc TESTS=TestAccKendraDataSource_Configuration_TemplateConfiguration PKG=kendra                             

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20 -run='TestAccKendraDataSource_Configuration_TemplateConfiguration'  -timeout 360m
=== RUN   TestAccKendraDataSource_Configuration_TemplateConfiguration
=== PAUSE TestAccKendraDataSource_Configuration_TemplateConfiguration
=== CONT  TestAccKendraDataSource_Configuration_TemplateConfiguration
--- PASS: TestAccKendraDataSource_Configuration_TemplateConfiguration (400.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     405.552s

DavidTanner avatar Jan 22 '24 22:01 DavidTanner

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Jan 22 '24 22:01 github-actions[bot]

Thank you for your contribution! :rocket:

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

github-actions[bot] avatar Jan 22 '24 22:01 github-actions[bot]

@justinretzolk What do I need to do so this can move forward?

DavidTanner avatar Feb 23 '24 03:02 DavidTanner

@jar-b, @YakDriver, @gdavison, @ewbankkit what do I need to do to get eyes on this PR?

DavidTanner avatar Mar 08 '24 22:03 DavidTanner

According to AWS, support for connectors configured using the older architecture (I.e. connectors NOT created with the TemplateConfiguration object) is scheduled to end by June 2024.

AWS also states: "Connectors configured using the older console and API architecture will continue to function as configured. However, you won’t be able to edit or update them."

This seems pretty urgent. Can this issue be prioritized so we can have a valid configuration option before before support ends?

AWS doc ref: https://docs.aws.amazon.com/kendra/latest/dg/data-source-s3.html

Note Amazon Kendra now supports an upgraded Amazon S3 connector.

The console has been automatically upgraded for you. Any new connectors you create in the console will use the upgraded architecture. If you use the API, you must now use the TemplateConfiguration object instead of the S3DataSourceConfiguration object to configure your connector.

Connectors configured using the older console and API architecture will continue to function as configured. However, you won’t be able to edit or update them. If you want to edit or update your connector configuration, you must create a new connector.

We recommended migrating your connector workflow to the upgraded version. Support for connectors configured using the older architecture is scheduled to end by June 2024.

dnlloyd avatar Jun 17 '24 19:06 dnlloyd