terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Glue Ray jobs fail to update

Open bobthemighty opened this issue 1 year ago • 4 comments

Description

Prior to this commit, updates to Glue Ray jobs fail, because the parameter Timeout is read from the remote resource, but is read only for Ray jobs.

Relations

Closes #35013

References

Output from Acceptance Testing

Before

make testacc TESTS=TestAccGlueJob_rayJobUpdates PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_rayJobUpdates'  -timeout 360m
=== RUN   TestAccGlueJob_rayJobUpdates
=== PAUSE TestAccGlueJob_rayJobUpdates
=== CONT  TestAccGlueJob_rayJobUpdates
    job_test.go:763: Step 2/2 error: Error running apply: exit status 1

        Error: updating Glue Job (tf-acc-test-4350313745659555033): InvalidInputException: Timeout not supported for Ray jobs
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "19e6dcb9-a186-477a-8392-0ce98d06c13b"
          },
          Message_: "Timeout not supported for Ray jobs"
        }

          with aws_glue_job.test,
          on terraform_plugin_test.tf line 43, in resource "aws_glue_job" "test":
          43: resource "aws_glue_job" "test" {

--- FAIL: TestAccGlueJob_rayJobUpdates (26.41s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/glue	26.477s
FAIL
make: *** [GNUmakefile:346: testacc] Error 1

After

make testacc TESTS=TestAccGlueJob_ray PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_ray'  -timeout 360m
=== RUN   TestAccGlueJob_rayJob
=== PAUSE TestAccGlueJob_rayJob
=== RUN   TestAccGlueJob_rayJobUpdates
=== PAUSE TestAccGlueJob_rayJobUpdates
=== CONT  TestAccGlueJob_rayJob
=== CONT  TestAccGlueJob_rayJobUpdates
--- PASS: TestAccGlueJob_rayJob (24.21s)
--- PASS: TestAccGlueJob_rayJobUpdates (35.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	35.384s

bobthemighty avatar Dec 20 '23 15:12 bobthemighty

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

Any chance of a bump on this?

bobthemighty avatar Jan 26 '24 19:01 bobthemighty

Friends! This bug makes the Ray job resource useless because it can't be updated through Terraform. The fix is here and tested, and has sat for 2 months. Is there any way we can get this prioritised? I could go ask a few dozen friends to add emojis if that helps?

bobthemighty avatar Mar 08 '24 14:03 bobthemighty

bump on this. Work around that I've found is to destroy and recreate the offending glue job

nunezpaul avatar May 21 '24 15:05 nunezpaul

Mirroring the above, we've found that destroying and recreating the relevant glue job allows the changes to be applied, but this is cumbersome and results in the connection between the job and previous run logs being lost. Would greatly like to see this implemented.

Geoiv avatar Aug 01 '24 22:08 Geoiv