terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

datasource: add aws_s3_bucket_server_side_encryption_configuration (#26054)

Open jeremychauvet opened this issue 2 years ago • 3 comments

Description

This Merge Request adds a datasource for aws_s3_bucket_server_side_encryption_configuration resource.

Relations

Closes #26054 Closes #27369

References

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketEncryption.html#AmazonS3-GetBucketEncryption-response-ServerSideEncryptionConfiguration

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketServerSideEncryptionConfigurationDataSource_'  -timeout 180m
=== RUN   TestAccS3BucketServerSideEncryptionConfigurationDataSource_aes256
=== PAUSE TestAccS3BucketServerSideEncryptionConfigurationDataSource_aes256
=== RUN   TestAccS3BucketServerSideEncryptionConfigurationDataSource_kms
=== PAUSE TestAccS3BucketServerSideEncryptionConfigurationDataSource_kms
=== RUN   TestAccS3BucketServerSideEncryptionConfigurationDataSource_default_encryption
=== PAUSE TestAccS3BucketServerSideEncryptionConfigurationDataSource_default_encryption
=== CONT  TestAccS3BucketServerSideEncryptionConfigurationDataSource_aes256
=== CONT  TestAccS3BucketServerSideEncryptionConfigurationDataSource_default_encryption
=== CONT  TestAccS3BucketServerSideEncryptionConfigurationDataSource_kms
--- PASS: TestAccS3BucketServerSideEncryptionConfigurationDataSource_default_encryption (42.72s)
--- PASS: TestAccS3BucketServerSideEncryptionConfigurationDataSource_kms (44.30s)
--- PASS: TestAccS3BucketServerSideEncryptionConfigurationDataSource_aes256 (44.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 44.770s

jeremychauvet avatar Apr 18 '23 11:04 jeremychauvet

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Apr 18 '23 11:04 github-actions[bot]

All issues detected by CI fixed. PR ready for review 👍🏼

jeremychauvet avatar Apr 20 '23 08:04 jeremychauvet

Really wanting this. Can we get it pushed out?

kieran-lowe avatar Jun 28 '24 12:06 kieran-lowe