terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

r/aws_ecs_task_execution: Add new resource

Open md5 opened this issue 1 year ago • 5 comments

Description

This pull request adds an aws_ecs_task_execution resource to complement data.aws_ecs_task_execution as added in #29783

Relations

Relates #29871

References

This is almost an exact copy of task_execution_data_source.go and its tests. The main difference between the resource schemas is that ForceNew has been added to all non-computed fields in the schema. There are possibly better patterns for making the code between the two more DRY.

Output from Acceptance Testing

I'm unable to run testacc successfully because a process in our account automatically tags the default security group of any VPC if it has any ingress or egress rules. This causes the refresh to always come back dirty...

md5 avatar Mar 14 '23 03:03 md5

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Mar 14 '23 03:03 github-actions[bot]

If this approach looks OK, I can work up some docs

md5 avatar Mar 14 '23 04:03 md5

Please someone merge this, it would be so helpful!

maybe someone like @jar-b who created the similar data source could help move this forward

mcfedr avatar Aug 11 '23 07:08 mcfedr

Is there any chance this will get merged? I would like to use it to run an ECS task only when applying, and this should do just that

mikicz avatar Jan 10 '24 09:01 mikicz

I would love to see support for CRUD as well just like aws_lambda_invocation resource

briantist avatar Feb 23 '24 21:02 briantist