terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

d/aws_ecs_cluster: add capacity_provider attributes

Open andrewradamis-paay opened this issue 2 years ago • 1 comments

…y_providers attributes

Description

Relations

Closes #0000

References

Output from Acceptance Testing

$ make testacc PKG=ecs TESTS=TestAccECSClusterDataSource
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSClusterDataSource'  -timeout 180m
=== RUN   TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN   TestAccECSClusterDataSource_ecsClusterCapacityProvider
=== PAUSE TestAccECSClusterDataSource_ecsClusterCapacityProvider
=== CONT  TestAccECSClusterDataSource_ecsCluster
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
=== CONT  TestAccECSClusterDataSource_ecsClusterCapacityProvider
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (38.91s)
--- PASS: TestAccECSClusterDataSource_ecsClusterCapacityProvider (38.91s)
--- PASS: TestAccECSClusterDataSource_ecsCluster (38.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        41.651s

andrewradamis-paay avatar Feb 24 '23 18:02 andrewradamis-paay

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Feb 24 '23 18:02 github-actions[bot]

any plans to merge this PR ?

bbratchiv avatar Jul 12 '23 11:07 bbratchiv

@ewbankkit Is this something you can review?

1oglop1 avatar Oct 15 '23 12:10 1oglop1

:+1:

pazderak avatar Jan 11 '24 08:01 pazderak

Hello @andrewradamis-paay - thank you for your work. Would you mind to rebase your MR please?

pazderak avatar Jan 15 '24 08:01 pazderak

Hi @andrewradamis-paay

Thanks a bunch for your contribution! 🙌

I was just wondering if you could rebase your changes to the latest version? That way, we can make sure everything is up-to-date and get another round of reviews and merge sooner now.

Thanks in advance for your help! 😊

kg-aws avatar Jul 24 '24 13:07 kg-aws