terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Added FIS support for EKS Cluster

Open akshaychopra5207 opened this issue 2 years ago • 4 comments

Description

This is to fix a validation failure for Cluster(EKS Cluster)

Relations

Closes #27314

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccFISExperimentTemplate_eks  PKG=fis
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISExperimentTemplate_eks'  -timeout 180m
=== RUN   TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== CONT  TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_eks (647.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        648.932s
...

akshaychopra5207 avatar Oct 19 '22 19:10 akshaychopra5207

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Oct 19 '22 19:10 github-actions[bot]

Any update on when this can be picked up ? @ewbankkit

akshaychopra5207 avatar Oct 28 '22 08:10 akshaychopra5207

Hi @ewbankkit, can you please revise this open PR? This bug still occurs on the latest version. Can you tell me what has to be done? First, of course rebasing 😂

bcubk avatar Nov 28 '22 20:11 bcubk

if necesssary, I would take it and do the rest of the work

bcubk avatar Nov 28 '22 20:11 bcubk

any news on this one?

akshaychopra5207 avatar Feb 14 '23 07:02 akshaychopra5207

@akshaychopra5207 Thanks for the contribution :tada: :clap:.

ewbankkit avatar Apr 27 '23 18:04 ewbankkit

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Apr 28 '23 00:04 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 28 '23 02:05 github-actions[bot]