terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Adds missing anonymous_auth_enabled parameter

Open dpattmann opened this issue 3 years ago • 1 comments

Description

The function flattenAdvancedSecurityOptions, used from the aws_opensearch_domain resource, tries to set anonymous_auth_enabled to a boolean value but the field is missing in the data resource model. This PR adds this field to the data resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26668

Output from acceptance testing:

$ make testacc TESTS=TestAccOpenSearchDomainDataSource_ PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_ -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (1597.77s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (1856.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	1858.491s
...

dpattmann avatar Sep 09 '22 22:09 dpattmann

Hi,

Any news regarding this PR? Is something missing to get it merged and available in the next release?

fmartinou avatar Oct 08 '22 19:10 fmartinou

Hi, can someone please confirm if this issue is fixed?

anithapriyanatarajan avatar Jan 11 '23 06:01 anithapriyanatarajan

We encountered the same problem and are stuck with an old provider version - a merge and release of the PR would really be appreciated!

neovatar avatar Jan 19 '23 10:01 neovatar

Any ETA for merging this PR? This fixes a critical issue for my team.

ltdeoliveira avatar Feb 28 '23 13:02 ltdeoliveira

@justinretzolk help would be appreciated, thanks.

barthel avatar Mar 08 '23 07:03 barthel

Thanks @ewbankkit for take over and pushing this issue.

barthel avatar Mar 13 '23 15:03 barthel

@dpattmann Thanks for the contribution :tada: :clap:.

ewbankkit avatar Mar 13 '23 16:03 ewbankkit

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Mar 16 '23 21:03 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Apr 16 '23 02:04 github-actions[bot]