terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Add support for networkmanager to peer with AWS Transit Gateway

Open NetDevAutomate opened this issue 3 years ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add a new networkmanager resource to create a peering request from a Core Network to AWS Transit Gateway.

New or Affected Resource(s)

  • aws_networkmanager_transit_gateway_peering_attachment

Potential Terraform Configuration

resource "aws_networkmanager_transit_gateway_peering_attachment" "example" {
  global_network_id           = aws_networkmanager_global_network.example.id
  peer_account_id              = aws_ec2_transit_gateway.peer.owner_id
  peer_region                      = data.aws_region.peer.name
  transit_gateway_id          = aws_ec2_transit_gateway.local.id
}

NetDevAutomate avatar Aug 10 '22 16:08 NetDevAutomate

I'm working on an attachment_acceptor resource that will pair with this proposal. however, the tgw type will have to be added to the acceptor

https://github.com/hashicorp/terraform-provider-aws/pull/26227

to implement you'd need to add 3 things:

  1. include the type in the validation func
  2. in the Create call, before AcceptAttachment is run, validate the attachment passed is not already accepted, you can copy this
  3. add a reference to the waiter, example here

drewmullen avatar Aug 10 '22 18:08 drewmullen

New resource(s) added in #26264:

  • aws_networkmanager_transit_gateway_peering
  • aws_networkmanager_transit_gateway_route_table_attachment

ewbankkit avatar Aug 23 '22 19:08 ewbankkit

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Sep 25 '22 02:09 github-actions[bot]