terraform-provider-aws
terraform-provider-aws copied to clipboard
New resource: `aws_grafana_workspace_api_key`
Community Note
- Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
Relates to https://github.com/hashicorp/terraform-provider-aws/issues/25100
$ make testacc PKG=grafana TESTS=TestAccGrafana_serial/ApiKey
Output from acceptance testing:
:~/terraform-provider-aws (f-aws_grafana_workspace_api_key)
$ make testacc PKG=grafana TESTS=TestAccGrafana_serial/ApiKey ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/ApiKey' -timeout 180m === RUN TestAccGrafana_serial === RUN TestAccGrafana_serial/ApiKey === RUN TestAccGrafana_serial/ApiKey/basic --- PASS: TestAccGrafana_serial (134.54s) --- PASS: TestAccGrafana_serial/ApiKey (134.54s) --- PASS: TestAccGrafana_serial/ApiKey/basic (134.54s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 134.618s :~/terraform-provider-aws (f-aws_grafana_workspace_api_key) $
...
Please also include a copy/paste of AccTest ouutput, not a screenshot. Thank you!
Acceptance test results
:~/terraform-provider-aws (f-aws_grafana_workspace_api_key) $ make testacc PKG=grafana TESTS=TestAccGrafana_serial/ApiKey ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/ApiKey' -timeout 180m === RUN TestAccGrafana_serial === RUN TestAccGrafana_serial/ApiKey === RUN TestAccGrafana_serial/ApiKey/basic --- PASS: TestAccGrafana_serial (139.80s) --- PASS: TestAccGrafana_serial/ApiKey (139.80s) --- PASS: TestAccGrafana_serial/ApiKey/basic (139.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 139.908s :~/terraform-provider-aws (f-aws_grafana_workspace_api_key) $
Is there more to be done on this change? Anything I could help with? We're keen to see this change land and stop managing Grafana API keys outside of Terraform!
Is there more to be done on this change? Anything I could help with? We're keen to see this change land and stop managing Grafana API keys outside of Terraform!
I have made the necessary changes. Just awaiting final review and closure.
LGTM 🚀. Please update the PR description at the top with the latest test results.
LGTM 🚀. Please update the PR description at the top with the latest test results.
Thanks Glen, updated as requested.
Hey, any chance to have it released today?
@ewbankkit can you have a look and let us know if this is good for merging?
@meetreks Thanks for the contribution :tada: :clap:.
@meetreks Thanks for the contribution 🎉 👏.
Thanks sir, this is really helpful.
This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.
For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.