r/aws_cognito_user_pool_domain - add update functionality for certificate_arn

[austinvalle]

• The certificate_arn can only be changed to a different ARN, it cannot be added or removed or it will force a re-create of the resource.
• Relevant AWS API: https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_UpdateUserPoolDomain.html

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14733

Output from acceptance testing:

 $ make testacc TESTS=TestAccCognitoIDPUserPoolDomain PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolDomain'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go-v2/service/route53domains v1.12.6
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.12.6
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.12
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.6
=== RUN   TestAccCognitoIDPUserPoolDomain_basic
=== PAUSE TestAccCognitoIDPUserPoolDomain_basic
=== RUN   TestAccCognitoIDPUserPoolDomain_custom
=== PAUSE TestAccCognitoIDPUserPoolDomain_custom
=== RUN   TestAccCognitoIDPUserPoolDomain_customCertUpdate
=== PAUSE TestAccCognitoIDPUserPoolDomain_customCertUpdate
=== RUN   TestAccCognitoIDPUserPoolDomain_disappears
=== PAUSE TestAccCognitoIDPUserPoolDomain_disappears
=== CONT  TestAccCognitoIDPUserPoolDomain_basic
=== CONT  TestAccCognitoIDPUserPoolDomain_customCertUpdate
=== CONT  TestAccCognitoIDPUserPoolDomain_custom
=== CONT  TestAccCognitoIDPUserPoolDomain_disappears
--- PASS: TestAccCognitoIDPUserPoolDomain_basic (40.26s)
--- PASS: TestAccCognitoIDPUserPoolDomain_disappears (43.91s)
--- PASS: TestAccCognitoIDPUserPoolDomain_custom (1268.51s)
--- PASS: TestAccCognitoIDPUserPoolDomain_customCertUpdate (1277.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	1279.780s
...

[github-actions[bot]]

Hey @austinvalle :wave: Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[DrFaust92]

Looks good austinvalle, see minor comment

[henryjcee]

@austinvalle want me to take this on to get it over the line?

[austinvalle]

@austinvalle want me to take this on to get it over the line?

Hi @henryjcee,

I think this PR is still waiting on prioritization/response. There was a request for change that I initially asked for clarification on, but haven't received a response yet.

If there are things I'm missing that might move the PR forward I won't deny help though! 😄

[henryjcee]

Oh noted, just saw your comment. All lgtm so I guess it's one for @DrFaust92.

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.