terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

Support for SES domain and email identity default configuration set

Open KyleKotowick opened this issue 3 years ago • 8 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

SES domain and email identities support setting a default configuration set (in the SESv2 API). Currently, Terraform does not support this feature for either of the relevant resources (aws_ses_domain_identity, aws_ses_email_identity).

The AWS API supports both specifying a default configuration set when creating a new email identity (CreateEmailIdentity), as well as setting a default configuration set for an existing email identity (PutEmailIdentityConfigurationSetAttributes).

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_ses_configuration_set" "test" {
  name = "some-configuration-set-test"
}

resource "aws_ses_domain_identity" "example" {
  domain = "example.com"
  default_configuration_set_name = aws_ses_configuration_set.test.name
}

resource "aws_ses_email_identity" "example" {
  email = "[email protected]"
  default_configuration_set_name = aws_ses_configuration_set.test.name
}

OR:

resource "aws_ses_configuration_set" "test" {
  name = "some-configuration-set-test"
}

resource "aws_ses_domain_identity" "example" {
  domain = "example.com"
}

resource "aws_ses_email_identity" "example" {
  email = "[email protected]"
}

// Since the PutEmailIdentityConfigurationSetAttributes API supports both domain and
// email identities, this resource should be able to support either as well?
resource "aws_ses_email_identity_default_configuration_set" "domain" {
  email_identity = aws_ses_domain_identity.example.domain
  configuration_set_name = aws_ses_configuration_set.test.name
}

resource "aws_ses_email_identity_default_configuration_set" "email" {
  email_identity = aws_ses_email_identity.example.domain
  configuration_set_name = aws_ses_configuration_set.test.name
}

References

KyleKotowick avatar Oct 02 '21 21:10 KyleKotowick

I am going to take care of this. As the first step we need to migrate from ses to sesv2 service from AWS SDK. Then the new attributes can be added.

kamilturek avatar Oct 06 '21 22:10 kamilturek

Do you have an estimation on this implementation?

elif-benli-engin avatar Mar 04 '22 15:03 elif-benli-engin

Any news on this?

edobrb avatar Apr 12 '22 08:04 edobrb

Any updates?!

mrvladis avatar Jun 23 '22 09:06 mrvladis

@kamilturek We're really looking forward for the default_configuration_set_name attribute for the 'aws_ses_domain_identity' and 'aws_ses_email_identity' resources. It would be great if this topic could be picked up again! Thank you!!!

gmx-git avatar Jul 03 '22 09:07 gmx-git

I'll try to pick this up again soon 🤞

kamilturek avatar Jul 03 '22 21:07 kamilturek

Is there any update regarding the estimation of this feature? Currently this is a blocker for our use case to use Terraform :(

florian-heer avatar Aug 10 '22 06:08 florian-heer

I see there's a plan and a pull request for moving to sesv2. Maybe we'll need to vote them up (👍) so they can pick up some traction. Here are the links: https://github.com/hashicorp/terraform-provider-aws/issues/26796 https://github.com/hashicorp/terraform-provider-aws/pull/26846

Hope this helps move this one forward as well!

gmx-git avatar Sep 22 '22 07:09 gmx-git

Hi there,

@ewbankkit / @kamilturek : This topic reports the issue for both domain and email identities. I think so far only the email identity was covered. Should the whole issue be closed in this case?

Is there maybe a plan to get the aws_sesv2_domain_identity resource implemented? I'd have a ton of uses for it! :)

gmx-git avatar Oct 26 '22 07:10 gmx-git

Hi there,

@ewbankkit / @kamilturek : This topic reports the issue for both domain and email identities. I think so far only the email identity was covered. Should the whole issue be closed in this case?

Is there maybe a plan to get the aws_sesv2_domain_identity resource implemented? I'd have a ton of uses for it! :)

@gmx-git There's no such thing as a domain identity in SES v2 API. The "email identity" supports both email addresses and domains. API reference: https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_CreateEmailIdentity.html

rav2040 avatar Oct 26 '22 20:10 rav2040

Yeah, looking at the API reference, it makes sense to have a single call to create the SES identity resources. Thanks guys for the implementation!

gmx-git avatar Oct 27 '22 12:10 gmx-git

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Oct 27 '22 22:10 github-actions[bot]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Nov 27 '22 02:11 github-actions[bot]