AWS Inspector SNS subscription support

[fedecz]

Based on PR: terraform-providers/terraform-provider-aws#3957 Fixes: #843

Fixed some issues covered in previous PR and fixed Tests

$ make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=120s -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.704s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.011s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.015s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/naming	0.069s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.025s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token	0.026s
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes	0.024s
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001	3.268s

make testacc TESTARGS='-run=TestAccAWSInspectorTemplate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSInspectorTemplate -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSInspectorTemplateEventSubscriptions_basic
=== PAUSE TestAccAWSInspectorTemplateEventSubscriptions_basic
=== RUN   TestAccAWSInspectorTemplateEventSubscriptions_update
=== PAUSE TestAccAWSInspectorTemplateEventSubscriptions_update
=== RUN   TestAccAWSInspectorTemplate_basic
=== PAUSE TestAccAWSInspectorTemplate_basic
=== CONT  TestAccAWSInspectorTemplateEventSubscriptions_basic
=== CONT  TestAccAWSInspectorTemplate_basic
=== CONT  TestAccAWSInspectorTemplateEventSubscriptions_update
--- PASS: TestAccAWSInspectorTemplateEventSubscriptions_basic (47.58s)
--- PASS: TestAccAWSInspectorTemplate_basic (62.62s)
--- PASS: TestAccAWSInspectorTemplateEventSubscriptions_update (141.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	141.465s

[ghost]

The commit is now almost a year old. Its a feature that is really missing.

[Szasza]

Hi @fedecz ,

Thank you for the PR, it is a feature which is really needed. Could you please address the review comments and the conflict?

Thank you in advance, it is greatly appreciated!

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

Superseded by https://github.com/hashicorp/terraform-provider-aws/pull/26334.

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.