terraform-plugin-framework icon indicating copy to clipboard operation
terraform-plugin-framework copied to clipboard

basetypes: fix equality for values with nil elementType

Open jar-b opened this issue 1 year ago • 1 comments

A MapValue, ListValue, or SetValue with a nil elementType is an invalid state, and therefore cannot verify equality with another value. These changes to the Equal method now returns false if either the receiver or argument have a nil elementType.

Closes #959

jar-b avatar Mar 18 '24 18:03 jar-b

Thanks @bendbennett - added separate changelog entries for each type. Let me know if you'd prefer a single entry instead!

jar-b avatar Mar 19 '24 13:03 jar-b

@bendbennett / @jar-b anything else need to happen here? Implementation change looks good to me 😄

bflad avatar Apr 16 '24 09:04 bflad

Apologies, I missed that this needed rebased. Should be ready now!

jar-b avatar Apr 16 '24 13:04 jar-b

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 18 '24 02:05 github-actions[bot]